Remove localized case studies content - #3
Closed
Kyle-Law wants to merge 1 commit into
Closed
Conversation
Follow-up to kubernetes#57043, which removed the English case studies section. Extends the same removal to every other locale that still had translated case studies: - bn (194 files), zh-cn (212 files), vi (190 files), ja (14 files), ko (6 files), it (4 files), pt-br (3 files) For each locale: - Delete content/<lang>/case-studies/ entirely. - Drop the {{< blocks/case-studies >}} homepage shortcode call from content/<lang>/_index.html, matching how kubernetes#57043 trimmed content/en/_index.html. - content/zh-cn/community/_index.html linked to /zh-cn/case-studies (the only locale with such a link); repointed it to CNCF's case studies page, matching the fix already applied to the English community page in kubernetes#57043. Not included: layouts/shortcodes/blocks/case-studies.html, layouts/case-studies/list.html, the case-studies.css wiring in layouts/partials/css.html, and the remaining per-company static/css/style_*.css files. Those become fully dead code once every locale's case studies are gone, but are left for a separate follow-up so this PR stays focused on content removal.
Author
|
Closing this. On reflection this was premature. it assumes a decision ("remove case studies for every locale") that hasn't actually been made. The only two maintainer-side signals on this are:
That heads-up hasn't happened yet even for the English change, and each of these locales (bn, it, ja, ko, pt-br, vi, zh-cn) has its own OWNERS/approvers who'd need to weigh in on removing their translated content. Closing rather than leaving this open as a live proposal ahead of that process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to kubernetes#57043, which removed the English case studies section.
Extends the same removal to every other locale that still had translated case studies content:
bn(194 files)zh-cn(212 files)vi(190 files)ja(14 files)ko(6 files)it(4 files)pt-br(3 files)For each locale:
content/<lang>/case-studies/entirely.{{< blocks/case-studies >}}homepage shortcode call fromcontent/<lang>/_index.html, matching how Remove case studies kubernetes/website#57043 trimmedcontent/en/_index.html.content/zh-cn/community/_index.htmlwas the only locale page linking directly into the section (/zh-cn/case-studies); repointed it to CNCF's case studies page, matching the fix already applied to the English community page in Remove case studies kubernetes/website#57043.Not included (left for a separate follow-up so this stays focused on content removal):
layouts/shortcodes/blocks/case-studies.html,layouts/case-studies/list.html, thecase-studies.csswiring inlayouts/partials/css.html, and the remaining per-companystatic/css/style_*.cssfiles. These become fully dead code once every locale's case studies are gone, but that's a template/CSS cleanup, not a content change.Note on process: localized content is normally under each language SIG's own review - this PR only handles the mechanical removal + the one broken link it would otherwise create. Worth a heads-up to the relevant l10n subprojects before merging, same as was flagged for the English removal in kubernetes#57043.