fix(editor): remove the redundant top-bar settings button - #465
Merged
Conversation
The gear icon between the theme toggle and Export opened the shortcuts configuration dialog — the same dialog already reachable as "Keyboard Shortcuts" from the OpenScreen wordmark menu. Unlike AI settings, which llm-providers.md documents as an intentional "two doors, one dialog", this second door was just a leftover. Removed the button and its icon import, the now-dead `topbar.settings` string from all 13 locales, and the two manual e2e checklist lines that tested or referenced the removed control. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
💤 Files with no reviewable changes (14)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe editor top bar no longer includes a direct settings button. Settings access remains in the application menu. Related translations and manual end-to-end checklist steps were removed or updated. ChangesEditor settings shortcut removal
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This removes a redundant editor control while preserving access to Keyboard Shortcuts through the existing menu; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
topbar.settingsstring from all 13 locales.Targets
main; will need to be cherry-picked into1.10.0.rc2.Test plan
tsc --noEmitcleanEditorTopBar.test.tsx,localeParity.test.ts,ProviderSettings.test.tsxpass (35 tests)🤖 Generated with Claude Code
Summary by CodeRabbit
Updates
Documentation