fix(editor): remove the redundant top-bar settings button (cherry-pick for 1.10.0-rc.2) - #478
Conversation
The gear icon between the theme toggle and Export opened the shortcuts configuration dialog — the same dialog already reachable as "Keyboard Shortcuts" from the OpenScreen wordmark menu. Unlike AI settings, which llm-providers.md documents as an intentional "two doors, one dialog", this second door was just a leftover. Removed the button and its icon import, the now-dead `topbar.settings` string from all 13 locales, and the two manual e2e checklist lines that tested or referenced the removed control. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@coderabbitai review |
|
Warning Review limit reached
Next review available in: 13 minutes Limit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
Summary
Cherry-pick of #465 onto
release/v1.10.0for the next RC.topbar.settingsstring from all 13 locales.Related issue
No tracked issue — reported directly by screenshot. See #465 for the original change.
Type of change
Release impact
Desktop impact
Screenshots / video
Not attached — this removes one existing top-bar icon with no other visual change.
Testing
Cherry-picked commit is identical in content to the one already merged and verified on
main(#465). Re-ran on top ofrelease/v1.10.0(currently1.10.0-rc.1, rebased onto the latest tip):npx tsc --noEmit— cleannpx vitest runover the affected suites (EditorTopBar,localeParity,ProviderSettings) — 35 tests passnpx biome checkon all changed files — cleanCherry-picked cleanly with one trivial auto-merge in
manual-e2e-checklist.md(unrelated doc edits landed nearby on the release branch since it was cut), same 15-file diff as #465.🤖 Generated with Claude Code