Skip to content

fix(tri): restore the test build — dedup XADC tests, port stale-API tests, commit the missing helper - #2237

Merged
gHashTag merged 2 commits into
masterfrom
fix/tri-tests-dedup
Aug 19, 2026
Merged

fix(tri): restore the test build — dedup XADC tests, port stale-API tests, commit the missing helper#2237
gHashTag merged 2 commits into
masterfrom
fix/tri-tests-dedup

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Master's cargo test -p tri --no-run fails with 19 errors (duplicated XADC block, pre-tuple-API tests, a helper called by a committed test but never itself committed — recovered from aaecfb0). 12/12 affected tests pass after the port. Same failure mode as #2227: build check green, test build broken, every PR inherits. Closes #2236

🤖 Generated with Claude Code

…API tests, commit the missing helper

The XADC test block existed twice (a batch merge kept both vintages);
three resolve_pvt_context tests and the cold_por test were written
against the pre-tuple API; and a committed snapshot test called
assert_report_superset, whose definition no commit on master ever
carried -- recovered from the wave that used it (aaecfb0) and
restored. 12/12 affected tests pass. Same failure mode as #2227:
the plain build check was green while the test build was broken.

Closes #2236

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-19 15:52:48 UTC

Summary

Status Count
Total Open PRs 29
PRs with Failing Checks 12
PRs with All Checks Green 17
READY 9
FAILING 12
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=54d19991b0c2 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag enabled auto-merge (squash) August 19, 2026 18:43
@gHashTag
gHashTag merged commit af8c76e into master Aug 19, 2026
8 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

master: tri test build broken — duplicated XADC test block, stale-API resolve/cold_por tests, helper never committed

1 participant