fix(tri): restore the test build — dedup XADC tests, port stale-API tests, commit the missing helper - #2237
Merged
Merged
Conversation
…API tests, commit the missing helper The XADC test block existed twice (a batch merge kept both vintages); three resolve_pvt_context tests and the cold_por test were written against the pre-tuple API; and a committed snapshot test called assert_report_superset, whose definition no commit on master ever carried -- recovered from the wave that used it (aaecfb0) and restored. 12/12 affected tests pass. Same failure mode as #2227: the plain build check was green while the test build was broken. Closes #2236 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Aug 19, 2026
gHashTag
enabled auto-merge (squash)
August 19, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's
cargo test -p tri --no-runfails with 19 errors (duplicated XADC block, pre-tuple-API tests, a helper called by a committed test but never itself committed — recovered from aaecfb0). 12/12 affected tests pass after the port. Same failure mode as #2227: build check green, test build broken, every PR inherits. Closes #2236🤖 Generated with Claude Code