fix(tri): restore the seven definitions a batch merge dropped - #2228
Merged
Conversation
…_config's output refactor A wave-loop batch merge kept the call sites and lost the definitions: SmokeGateReport, pvt_context_inside_envelope, synthetic_pvt_context, cclk_period_ns, verify_lean, extract_source_from_lean. Restored verbatim from the commits that introduced them (Wave Loops 437/441/443/453). bit_config now actually captures output (status() cannot), passes stderr through, and the console arm prints the string it now returns. Disclosure: rustfmt over fpga.rs also canonicalised eleven pre-existing unformatted spots left by the same merges; no semantic change in them. Closes #2227 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts: # docs/NOW.md
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Aug 19, 2026
Closed
gHashTag
added a commit
that referenced
this pull request
Aug 20, 2026
… reads (#2305) `dry_run_sweep_ok` had two mentions in cli/tri/src/fpga.rs: declared `false` at 6098, read in the `passed` conjunction at 6333, never assigned `true`. The dry-run CCLK sweep succeeds and prints its OK line, but nothing recorded it, so smoke_gate() returned passed=false for every possible input. Its siblings survive this by being read guarded -- (!run_verify_lean || verify_lean_ok) is vacuously true when the phase is not requested. The `&& dry_run_sweep_ok` term is unguarded, so it failed the gate unconditionally. This is the second occurrence of the shape documented at line 6167 for verify_lean_ok, restored from 494e659 after the #2228 batch merge dropped it. dry_run_sweep_ok went out in the same merge and was missed. The fix mirrors the restored code: at the point where success is established -- after the variant-count bail, before the OK line -- set the flag and write the report entry, in that order. The report entry is part of the fix, not extra scope: report["dry_run_sweep"] was written only on failure, so on success it kept the null from its initializer, and the test requires that key to be an object with status "ok". Not compiled: the authoring machine had ~148 MB free, too little to check out the repo or run cargo. Verified textually -- three mentions instead of two, placement mirrors verify_lean_ok, dry_report/variant_count in scope, and dry_run_sweep is an existing field on the deny_unknown_fields report schema. The verdict conjunction is unchanged; no phase was dropped to make it pass. Closes #2304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores master's
cargo build -p tri. Definitions recovered verbatim from Wave Loops 437/441/443/453; bit_config's half-finished status()/output() refactor completed. Master's own build check was green from a pre-break commit — every PR failed on it (found by the #2223 gate). Closes #2227🤖 Generated with Claude Code