fix: 신원보증서 canonical key 처리 보완 - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
identity_guaranty_v129의 기존 record rule에foreign_namecanonical key를 대체 key로 등록했습니다./api/v1/documents/generate로 생성하는 회귀 테스트를 추가했습니다.변경 이유
map_identity_guaranty()는foreign_name,foreign_family_name,foreign_given_name을 함께 전달하지만, 기존 신원보증서 record rules에는foreign_name이 없었습니다.이 때문에 canonical key 전체가 record rules에 포함되지 않아 기존 dynamic-label 생성 경로로 fallback하고, HWPX 생성 시 422가 발생할 수 있었습니다.
Renewal과 Server의 canonical key 계약은 변경하지 않고, 기존
TEMPLATE_RULES를 source of truth로 재사용하도록 최소 수정했습니다.테스트
결과:
111 passedgit diff --check통과