fix(bindings): close CI regressions on ci-fixes - #918
Merged
kushti merged 7 commits intoSep 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a focused follow-up stacked on #916 (
ci-fixes). It incorporates the actionable binding/test findings from Odiseus's review while preserving the upstream 30-secondNodeConfdefault added in45e4b412.No dependency manifest or custom timeout API is changed here.
Changes
Disposableidentity when consumers enableesnext.disposable.ErgoBoxCandidateconstructor stub and exercise it with mypy in Python CI.host:port), with deterministic alias/deduplication coverage.x86_64wheel job from the retiredmacos-13runner tomacos-15-intel.Related PRs
core3pin in Dependencies updates for github CI actions #916 removes hidden aliasing/direct semver drift, but does not establish Ergo-controlled custody or eliminate future yank risk.Validation
ergo-lib-c-core --features rest: 7 passed, including completion-first, abort-first, repeated abort, synchronous validation ownership, drop semantics, and 128 completion/abort races.ergo-lib-c --features rest: consumer test/check passed; Clippy with warnings denied and rustfmt passed.esnext.disposable./infotest because no node was running at127.0.0.1:9053; peer discovery, public NiPoPoW, and the two-proof SPV workflow passed.c34be562: 27 checks passed, including Swift/iOS, browser JS and generated TypeScript declarations, every Python wheel lane, andmacos-15-intel/x86_64. The release job and npm publication steps were skipped as intended for a pull request.Scope
This does not redesign the production Swift async wrappers or change pre-existing panic/runtime-shutdown semantics. It does not select a dependency-custody strategy, merge #916, tag a version, publish packages, or perform a release.