Conversation
Coverage Report for CI Build 33626528196Coverage increased (+0.07%) to 86.961%Details
Uncovered Changes
Coverage Regressions5 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
|
Reviewed the full diff. Gating npm alpha publication on First,
I compared its relevant non-std I/O implementation with Second, the JS and Swift SPV tests previously required two independent NiPoPoW proofs; both now pass with one. That silently removes multi-proof verifier coverage. Please retain a deterministic two-proof test rather than trading that assertion for network reliability. One smaller issue: the new Swift/WASM fallback node configurations have no request timeout, so a stalled first node may never reach the fallback. The PyO3/wasm-bindgen migrations, test-only Rust REST helpers, and npm publish gating otherwise look sound. |
fix(bindings): close CI regressions on ci-fixes
a-shannon
left a comment
There was a problem hiding this comment.
Reviewed the current c02bc0b head after #918. The functional regressions identified during review are addressed, all current checks are green, and the feature-gated C REST suite passes 7/7 on the exact head. I found no remaining code blocker to merging #916.
The 0.29.0 version, packaging, and release-gate work is being handled in a separate follow-up PR before tagging.
No description provided.