Fix calibration fallback warning and surface EPWtcc/IAWtcc for unknow… - #129
Open
almilder wants to merge 1 commit into
Open
Fix calibration fallback warning and surface EPWtcc/IAWtcc for unknow…#129almilder wants to merge 1 commit into
almilder wants to merge 1 commit into
Conversation
…n shots The unknown-shot-number fallback in get_calibrations had a raise Warning(...) inside a try/except KeyError, which doesn't actually catch Warning (it isn't a KeyError), so it crashed instead of warning. Switched to warnings.warn(...), and surfaced EPWtcc/IAWtcc from detector_specs for the imaging-calibration fallback path (previously only the non-imaging path set fallback values). Docs updated to describe the detector_specs fallback fields. Also replaces sa_lookup's nine near-identical elif beam == branches with a data-driven dict lookup (verified exact match on all beams and the error path).
almilder
force-pushed
the
pr-2-calibration
branch
from
August 20, 2026 18:47
eaa8a9a to
3e9f91e
Compare
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raise Warning(...)inside atry/except KeyError, which doesn't actually catch Warning (it isn't a KeyError), so it crashed instead of warning. Switched towarnings.warn(...).Test plan