Close matplotlib figures in the data visualizer to prevent an OOM error - #131
Open
almilder wants to merge 1 commit into
Open
Close matplotlib figures in the data visualizer to prevent an OOM error#131almilder wants to merge 1 commit into
almilder wants to merge 1 commit into
Conversation
launch_data_visualizer opened several figures per shot without ever closing them; over a long run (or many shots) these accumulate and can exhaust memory. Adds plt.close(fig) after each figure is saved, and saves the previously-unsaved temporal-comparison figure. Also switches the lineouts-with-background plot to gate on background:report_background instead of hardcoding background:type in ["fit", "pixel"].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan