craft: check herbs before buy/forage; workorders: re-read logbook before turn-in - #7514
craft: check herbs before buy/forage; workorders: re-read logbook before turn-in#7514simtel12 wants to merge 3 commits into
Conversation
Avoid bank/stock trips when ingredients are already on hand, skip remedy when funds or herbs cannot be acquired, and support `;craft alchemy debug`.
Forge workorders trusted ask quantity and claimed success even when the NPC said the order wasn't complete. Craft until the logbook reports zero remaining, and stop claiming turn-in on incomplete give responses.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Summary
;craft alchemy debugsupport, avoiding unnecessary bank/stock trips when ingredients are already on hand and skipping remedy when funds or herbs can't be acquiredTest plan
rspec spec/workorders_spec.rbpasses (98 examples, 0 failures)ruby -c craft.lic/ruby -c workorders.licsyntax check clean