Skip to content

craft: check herbs before buy/forage; workorders: re-read logbook before turn-in - #7514

Open
simtel12 wants to merge 3 commits into
elanthia-online:mainfrom
simtel12:craft-workorders-fixes
Open

craft: check herbs before buy/forage; workorders: re-read logbook before turn-in#7514
simtel12 wants to merge 3 commits into
elanthia-online:mainfrom
simtel12:craft-workorders-fixes

Conversation

@simtel12

@simtel12 simtel12 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • craft: check alchemy herbs before buy/forage and add ;craft alchemy debug support, avoiding unnecessary bank/stock trips when ingredients are already on hand and skipping remedy when funds or herbs can't be acquired
  • workorders: re-read the forging logbook's remaining count before turn-in instead of trusting the originally asked quantity, and stop claiming turn-in success on incomplete give responses

Test plan

  • rspec spec/workorders_spec.rb passes (98 examples, 0 failures)
  • ruby -c craft.lic / ruby -c workorders.lic syntax check clean

Avoid bank/stock trips when ingredients are already on hand, skip remedy when funds or herbs cannot be acquired, and support `;craft alchemy debug`.
Forge workorders trusted ask quantity and claimed success even when the
NPC said the order wasn't complete. Craft until the logbook reports
zero remaining, and stop claiming turn-in on incomplete give responses.
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5be5fcb3-810f-4494-960d-3f05a674564f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MahtraDR

Copy link
Copy Markdown
Collaborator

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants