workorders: add ;continue to resume an in-progress order from the logbook - #7518
Open
simtel12 wants to merge 5 commits into
Open
workorders: add ;continue to resume an in-progress order from the logbook#7518simtel12 wants to merge 5 commits into
simtel12 wants to merge 5 commits into
Conversation
Avoid bank/stock trips when ingredients are already on hand, skip remedy when funds or herbs cannot be acquired, and support `;craft alchemy debug`.
Forge workorders trusted ask quantity and claimed success even when the NPC said the order wasn't complete. Craft until the logbook reports zero remaining, and stop claiming turn-in on incomplete give responses.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
…book Reads the discipline logbook to recover the item and remaining quantity of an order already accepted (e.g. after a disconnect), instead of canceling and re-requesting one. Skips straight to turn-in when the logbook reports the order already complete.
simtel12
force-pushed
the
workorders-continue
branch
from
August 9, 2026 01:32
7dc686c to
670fdbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
;workorders <discipline> continueto resume an in-progress work order by reading the discipline logbook, instead of canceling and re-requesting one (e.g. after a disconnect). Recovers the recipe and remaining quantity from the logbook text, and skips straight to turn-in when the logbook reports the order already complete.Stacked on #7514 since
resume_work_orderrelies onlogbook_remaining, added there. The diff below includes #7514's commits until that merges; it'll shrink to just this feature once it does.Test plan
rspec spec/workorders_spec.rbpasses (106 examples, 0 failures)ruby -c workorders.licsyntax check clean