Skip to content

Remove DashSync Coinbase transaction metadata tail - #902

Merged
llbartekll merged 1 commit into
swift-sdk-integrationfrom
codex/dashsync-coinbase-transaction-tail-xcode
Jul 30, 2026
Merged

Remove DashSync Coinbase transaction metadata tail#902
llbartekll merged 1 commit into
swift-sdk-integrationfrom
codex/dashsync-coinbase-transaction-tail-xcode

Conversation

@llbartekll

Copy link
Copy Markdown

Summary

  • replace Coinbase transaction tagging and metadata reads from DWEnvironment with an active-wallet SwiftDashSDK snapshot
  • add wallet-scoped deterministic receive matching, prevent transaction reuse, and invalidate metadata cache on SDK and wallet events
  • remove unused DSTransaction and DSAccount categories plus stale bridging/project references
  • add focused resolver, byte-order, wallet-isolation, icon, and stale-cache tests
  • update the DashSync migration and teardown ledgers

Verification

  • focused Coinbase test bundle builds successfully
  • dashpay arm64 iOS Simulator build passes without signing
  • git diff --check passes
  • plutil lint of the Xcode project passes
  • dashwallet build is blocked by the local missing Watch simulator runtime; the untouched swift-sdk-integration baseline fails with the identical error: No simulator runtime version from [23S303] available to use with watchsimulator SDK version 23T570
  • focused runtime execution is blocked by the unavailable CoreSimulatorService

Manual smoke

  • Coinbase to wallet transaction receives Coinbase and received icons
  • wallet to Coinbase transaction retains Coinbase and sent icons
  • metadata survives relaunch
  • ordinary transactions remain untagged
  • switching the active wallet does not mix pending matches or cached metadata

Apple Watch, Podfile, storage/keychain, platform SDK, TransferAmountViewModel, invitation/profile flows, and DASHSYNC_KEY_MIGRATION.md are unchanged.

@llbartekll
llbartekll requested a review from romchornyi July 30, 2026 09:53
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5aa3ee4f-97d7-435d-9a0d-c5cd887f23a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@llbartekll
llbartekll merged commit d9a9706 into swift-sdk-integration Jul 30, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants