Skip to content

fix(coinbase): Fix Coinbase metadata wallet context - #904

Merged
llbartekll merged 2 commits into
swift-sdk-integrationfrom
codex/fix-coinbase-metadata-wallet-context
Jul 30, 2026
Merged

fix(coinbase): Fix Coinbase metadata wallet context#904
llbartekll merged 2 commits into
swift-sdk-integrationfrom
codex/fix-coinbase-metadata-wallet-context

Conversation

@llbartekll

Copy link
Copy Markdown

Summary

  • capture the Dash receive address and wallet ID atomically, then carry that wallet context through the Coinbase send response
  • retain fallback Coinbase transfers for their originating wallet across runtime rebuilds without fetching a full snapshot while tracking
  • throttle metadata refreshes triggered by Core Data saves and correct the migration ledger left stale by Remove DashSync Coinbase transaction metadata tail #902

Follow-up to #902. The public transferFromCoinbaseToDashWallet API and direct network.hash behavior remain unchanged.

Validation

  • git diff --check
  • plutil -lint DashWallet.xcodeproj/project.pbxproj
  • dashpay Debug build for arm64 iOS Simulator
  • Focused CoinbaseTransactionMetadataTests and the dashwallet build are blocked before app compilation by the local watchOS runtime mismatch: runtime 23S303 is unavailable for watch simulator SDK 23T570.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4df202fb-43df-4038-8ecf-1a6dd98d232f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@llbartekll llbartekll changed the title Fix Coinbase metadata wallet context fix(coinbase): Fix Coinbase metadata wallet context Jul 30, 2026
@llbartekll
llbartekll requested a review from romchornyi July 30, 2026 10:47
@llbartekll
llbartekll merged commit b2ef052 into swift-sdk-integration Jul 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants