Skip to content

Remove DashSync avatar and profile tail - #899

Merged
llbartekll merged 1 commit into
codex/dashsync-coinbase-uphold-tailfrom
codex/dashsync-avatar-profile-tail
Jul 30, 2026
Merged

Remove DashSync avatar and profile tail#899
llbartekll merged 1 commit into
codex/dashsync-coinbase-uphold-tailfrom
codex/dashsync-avatar-profile-tail

Conversation

@llbartekll

Copy link
Copy Markdown

Summary

  • replace the DashSync avatar transport with an app-owned Moya/HTTPClient Imgur client while preserving DWUploadAvatarModel's Objective-C/KVO contract
  • remove the unreachable outgoing invitation create/send/history flow and its exclusive assets while retaining link, paste, scan, claim, inviter-preview, and post-claim contact paths
  • move active Home/profile/edit reads and writes to DWCurrentUserIdentityInfo and DWProfileUpdateBridge
  • remove dead legacy profile/QR containers, DSBlockchainIdentity UI categories, and the orphan avatar view
  • update migration/teardown documentation and mark the superseded outgoing-invitations proposal as historical

Avatar behavior

  • exact image / image.jpg / image/jpeg multipart contract
  • existing 600×600 resize and JPEG quality 0.5
  • delete-before-upload with four total delete attempts; upload continues after exhausted delete failures
  • no automatic upload retry; manual Retry restarts the complete cycle
  • composite cancellation plus request/attempt generations suppress stale transport completions and state mutations
  • all state and resultURLString mutations remain on the main thread

Verification

  • dashpay Debug generic arm64 iOS Simulator build: passed
  • focused avatar test bundle compilation: passed (16 tests)
  • plutil -lint DashWallet.xcodeproj/project.pbxproj: passed
  • git diff --check: passed
  • DashSync import/type and deleted-asset caller audits: passed

The native dashwallet build and test scheme remain blocked before app compilation by the local Watch runtime mismatch (23S303 runtime vs 23T570 SDK). The identical failure was reproduced on the untouched base. An isolated dashpay test-host diagnostic compiled the focused tests; runtime execution remains unavailable because that diagnostic host duplicates app classes.

Scope

Apple Watch, Podfile DashSync entries, storage/keychain, SDK/platform, DASHSYNC_KEY_MIGRATION.md, and DWUpholdMainnetConstants.m are unchanged.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6257d0ac-0a6b-4174-aaa9-f598d966fccc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@llbartekll
llbartekll requested a review from romchornyi July 29, 2026 15:00
@llbartekll
llbartekll merged commit da9d049 into codex/dashsync-coinbase-uphold-tail Jul 30, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants