Skip to content

refactor: remove DashSync avatar and profile tail - #901

Merged
llbartekll merged 4 commits into
swift-sdk-integrationfrom
codex/dashsync-avatar-profile-tail
Jul 30, 2026
Merged

refactor: remove DashSync avatar and profile tail#901
llbartekll merged 4 commits into
swift-sdk-integrationfrom
codex/dashsync-avatar-profile-tail

Conversation

@llbartekll

Copy link
Copy Markdown

Context

Retarget of #899 to the correct base branch. PR #899 was accidentally merged into codex/dashsync-coinbase-uphold-tail.

@romchornyi approved the exact implementation commit 64573f7 in #899. The source branch now also contains the latest swift-sdk-integration tip; the resulting tree matches the previously verified cherry-pick onto swift-sdk-integration.

Summary

  • replace DashSync avatar transport with the app-owned Moya/HTTPClient Imgur client while preserving the Objective-C/KVO model contract
  • remove the unreachable outgoing invitation flow while retaining incoming link, paste, scan, claim, inviter-preview, and post-claim contact paths
  • move active profile reads and writes to DWCurrentUserIdentityInfo and DWProfileUpdateBridge
  • remove dead legacy profile/QR containers and exclusive assets
  • update migration and teardown documentation

Verification carried over from #899

  • dashpay Debug generic arm64 iOS Simulator build passed
  • focused avatar test bundle compilation passed: 16 tests
  • project.pbxproj plutil lint passed
  • git diff check and dependency/caller audits passed

The dashwallet build and native test scheme remain blocked before app compilation by the same local Watch runtime mismatch documented in #899. Apple Watch, Podfile DashSync entries, storage/keychain, SDK/platform, DASHSYNC_KEY_MIGRATION.md, and DWUpholdMainnetConstants.m are unchanged.

llbartekll and others added 4 commits July 29, 2026 13:19
…ce to a skill

Remove sections a fresh session derives from the codebase itself
(Languages, generic directory layout, Targets, Patterns), keeping the
SwiftDashSDK adapter-layer pointer. Move Figma Dev Mode MCP setup and
the SVG-cleaning gotcha into a lazy-loaded figma-assets skill so they
only cost context during design work.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
docs: rightsize CLAUDE.md (cut derivable sections, Figma guidance → skill)
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 77810ed7-3a89-4cdc-9b5c-a01b96d76e31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@llbartekll
llbartekll merged commit 7d8207a into swift-sdk-integration Jul 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant