Skip to content

docs(dashsync): platform pin is plain v4.1-dev — integration branch retired - #796

Merged
QuantumExplorer merged 2 commits into
swift-sdk-integrationfrom
docs/platform-pin-v41dev
Jul 12, 2026
Merged

docs(dashsync): platform pin is plain v4.1-dev — integration branch retired#796
QuantumExplorer merged 2 commits into
swift-sdk-integrationfrom
docs/platform-pin-v41dev

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Every app-required platform surface has now merged to v4.1-dev (fee threading; RawKeySigner #4097; TestnetFaucet #4098; SPV filter-rescan #4099; TransactionDecoder via key-wallet-ffi; classified peers), and the app builds green against it — verified at app tip 62a7eb40c vs origin/v4.1-dev tip 0bfdc5745c, sim xcframework rebuilt from pure v4.1-dev, dashpay arm64-sim BUILD SUCCEEDED, installed and launched on the QA sim. The local/tx-decode-plus-v4.1-dev-dashwallet integration branch is retired.

Remaining nuance documented in the note: the exact-fee VALUE from send_payment lands with platform #4049 (rust-dashcore pin bump for dashpay/rust-dashcore#872) — display-only, ≤546 duffs.

🤖 Generated with Claude Code

…etired

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a1f70b60-91ce-4fd1-afe1-96a79e26c719

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/platform-pin-v41dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The verified v4.1-dev tip 0bfdc5745c is platform #4049's merge commit,
so the exact send_payment fee and the faucet PoW cap (#4100) are
already in the verified build.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@QuantumExplorer

Copy link
Copy Markdown
Member Author

Updated: platform #4049 (exact send_payment fee) and #4100 (faucet PoW cap) both merged — and it turns out the verified v4.1-dev tip 0bfdc5745c is #4049's merge commit, so the verification build already included them. The pin note now records zero open nuances: plain v4.1-dev is fully sufficient.

🤖 Addressed by Claude Code

@QuantumExplorer
QuantumExplorer merged commit 8db1d31 into swift-sdk-integration Jul 12, 2026
2 checks passed
@QuantumExplorer

Copy link
Copy Markdown
Member Author

Refreshed to the latest v4.1-dev tip 88949b7144 per owner request. The new tip's seedless-shielded-bind change (platform #4125/#4126) altered shieldedWithdraw/shieldedUnshield to take a per-operation resolver: MnemonicResolver — adapted at both ShieldedTransferCoordinator call sites (same shape as SwiftExampleApp; the SDK holds the resolver alive across the FFI call). Verified: sim xcframework rebuilt from 88949b7144 with the new FFI types confirmed in the generated header, dashpay arm64-sim BUILD SUCCEEDED, installed + launched on the QA sim. This PR now carries the doc pin + that two-site adaptation.

🤖 Addressed by Claude Code

@QuantumExplorer QuantumExplorer changed the title docs(dashsync): platform pin is plain v4.1-dev — integration branch retired fix(wallet): target latest platform v4.1-dev — shielded resolver adaptation + pin retirement Jul 14, 2026
@QuantumExplorer QuantumExplorer changed the title fix(wallet): target latest platform v4.1-dev — shielded resolver adaptation + pin retirement docs(dashsync): platform pin is plain v4.1-dev — integration branch retired Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant