fix(wallet): adapt shielded spends to the SDK's per-operation resolver (latest v4.1-dev) - #799
Merged
QuantumExplorer merged 2 commits intoJul 14, 2026
Conversation
…r; pin at v4.1-dev tip The latest v4.1-dev (88949b7144) lands the seedless shielded bind (platform #4125/#4126): shieldedWithdraw/shieldedUnshield now take a per-operation MnemonicResolver supplying the Orchard spend authority. Pass MnemonicResolver() at both ShieldedTransferCoordinator call sites (the SDK holds it alive across the FFI call via withExtendedLifetime — same shape as SwiftExampleApp). Pin note refreshed to the newly verified tip. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #796 (which merged as docs-only before these commits landed on its branch — recovered here).
The latest platform
v4.1-devtip (88949b7144) lands the seedless shielded bind (platform #4125/#4126):shieldedWithdraw/shieldedUnshieldnow take a per-operationresolver: MnemonicResolversupplying the Orchard spend authority. This adapts bothShieldedTransferCoordinatorcall sites — a per-callMnemonicResolver(), same shape as SwiftExampleApp; the SDK holds the resolver alive across the FFI call viawithExtendedLifetime. Also refreshes the migration doc's pin note to the newly verified tip.Verified: sim xcframework rebuilt from
88949b7144(new FFI types confirmed present in the generated header), dashpay arm64-sim BUILD SUCCEEDED on the currentswift-sdk-integrationtip (8db1d310d), installed + launched on the QA sim. Without this, the app does not compile against the latestv4.1-dev.🤖 Generated with Claude Code