Bind Codex app-server threads at controlled launch - #234
Closed
myobie wants to merge 1 commit into
Closed
Conversation
This was referenced Aug 10, 2026
Contributor
Author
|
Folded into the reviewable implementation replacement #241 at exact head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five-PR review order
Please read the native-delivery set in this order:
deliver "mcp"/deliver "app-server"and preserves legacyding.These are two related dependency branches, not one linear Git stack: #232 and #233 are based on #229; #234 is based on #230. All five remain draft, unmerged, and held for Nathan's exact-head review.
Summary
deliver "app-server"canonical Codex tasks through a hidden controlled-launch wrapperThis is the topology and thread-binding slice only. It does not watch inboxes or send messages; those remain later adapter work. It is stacked on the delivery selector draft (#230) and implements the controlled-launch boundary specified by #233.
Contract details
codex-cli 0.145.0.thread/startedevent.idleoractive; the binding is then atomically rewritten with the new runtime incarnation.Verification
Green on exact head
fd5ba46:cargo check --lockedcargo test --locked --lib— 262 st2, 7 agent-spec, and 5 wire testscargo test --locked --test codex_app_server— 3/3cargo test --locked --test reconcile— 37/37cargo test --locked --test run— 45/45cargo test --locked eval_run::— 29/29cargo clippy --all-targets --locked— no new warnings; only existing repository warningsrustfmt --check --edition 2024 src/codex_app_server.rs tests/codex_app_server.rsLive Codex 0.145.0 evidence used one dedicated daemon/control/TUI topology. A fresh launch bound thread
019fec97-c2ed-74b3-a693-71f2ba62577c. A later controlled launch resumed that exact conversation, returnedFINAL_BIND, rotated the runtime incarnation, and rewrote the binding so it matched the new incarnation while retaining the same thread ID. Normal TUI exit left no Unix socket or disposable PTY residue.The repository-wide test command still encounters the pre-existing
catalog_diff::classification_only_and_nested_agent_filename_changes_are_exactfailure, reproduced on the base branch. The existingeval_uphost-qualified runtime-ID expectation mismatch is likewise present on the base. Neither path is changed here. Hosted Nix remains the PR gate.