Deliver Codex DINGs through app server - #236
Closed
myobie wants to merge 5 commits into
Closed
Conversation
Contributor
Author
|
Folded into the reviewable implementation replacement #241 at exact head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review order
PR #234 → PR #235 → this PR. Review the exact head; keep this draft until Nathan has reviewed it.
Summary
dnd, while Codex is in review or compaction, or whenever turn ownership is not exactSafety and scope
This is task 12 only. A successful app-server JSON response suppresses another submission in the current process, but it is not a typed
userMessagereceipt and does not archive the inbox file. The inbox stays authoritative until the agent reads and archives it. Persistent duplicate reconciliation and a typed receipt belong to task 13.Held or rejected delivery remains unread and retryable. A rejected exact steer has no fallback path, and no DING is typed into review, compaction, or an unowned turn.
Verification
cargo check --lockedcargo test --locked --lib --no-fail-fast(7 + 272 + 5 passed)cargo test --locked --test codex_app_server --no-fail-fast(3 passed)cargo clippy --locked --all-targets --no-deps(exit 0; existing unrelated warnings remain)rustfmt --edition 2024 --check src/codex_app_server.rsgit diff --checkIntegration verification
At exact review head
ea1d0a3:cargo test --locked subscribed_control_pump_delivers_a_typed_reference_to_the_real_fifo_headrustfmt --edition 2024 --check src/codex_app_server.rsgit diff --checkThe following provider observation was recorded on the prior behavior head. This correction changes only the test assertion boundary.
Prior live acceptance
Validated
74fe7bcc46e52b1afaf0eb582ef4ab5900382cb6with real Codex 0.145.0, thread019fecf8-50b5-73e0-867c-1320d09619e1, runtime incarnationc479d86755d64a63cc7ced21eba94355, and a fresh private catalog.8vfxfqstarted task019fecf8-958c-7f50-8b7e-4efc8238e04a; the agent read and archived the exact file211ykewas injected into existing turn019fecf9-240a-7763-ab18-45a3f271134b, with no new delivery turng37ww5remained unread while state washeld/reviewon turn019fecf9-e8cc-71a0-a320-da25a43c925a, even after the review hook changed presence toavailable; its DING appeared only after the review task completedzq0bh6remained unread while state washeld/compactionon turn019fecfb-94c7-77c3-b52b-7aea054f69d5; its DING appeared only aftercontext_compactedand task completion