Bump the interface version to 12.1.0 - #19
Conversation
The TOC still declared 120007. On patch 12.1.0 the client marks the addon out of date and CurseForge/Wago flag the file, so the number moves to 120100 even though nothing in the addon needed to change. The test stub's GetBuildInfo now returns the same build, and the README support badge follows. The prose references to patch 12.0 are left alone: they date the introduction of secret values, which is still 12.0.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29af2b8229
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,4 +1,4 @@ | |||
| ## Interface: 120007 | |||
| ## Interface: 120100 | |||
There was a problem hiding this comment.
Cut a new addon release for the interface bump
When this commit is merged without a new addon version and tag, the updated TOC will never reach existing CurseForge/Wago users: the inspected release workflow only publishes for v* tags (.github/workflows/release.yml:15-18) and rejects any tag whose version differs from the still-released ## Version: 2.5.0 (release.yml:49-60). Since the changelog also leaves this under Unreleased, bump the addon version and create the corresponding tag so this compatibility fix is actually packaged and uploaded.
Useful? React with 👍 / 👎.
Patch 12.1.0 is live and the TOC still declared
120007, so the client marksStatPanel out of date and CurseForge/Wago flag the file. Nothing in the addon
needed to change — this is just the compatibility flag.
StatPanel.toc—## Interface: 120100tests/wow_stub.lua— the fakeGetBuildInfo()returns12.1.0/120100so the stub keeps mirroring the live client
README.md— support badge readsWoW 12.1 MidnightCHANGELOG.md—[Unreleased]entryLeft alone on purpose: the "patch 12.0" prose in the README, store copy and
source comments dates the introduction of secret values, which is still 12.0.
The
120005indocs/PUBLISHING.mdis a worked example of the zero-paddingformat, not a claim about the current patch. The addon version stays at 2.5.0.
Tests were not run locally — no Lua interpreter on this machine. Nothing outside
the stub asserts on the build number.