Skip to content

Fix latest lints from rustc 1.98.0 - #5489

Merged
jasonwilliams merged 1 commit into
boa-dev:mainfrom
jedel1043:rustc-1.98.0
Aug 27, 2026
Merged

Fix latest lints from rustc 1.98.0#5489
jasonwilliams merged 1 commit into
boa-dev:mainfrom
jedel1043:rustc-1.98.0

Conversation

@jedel1043

Copy link
Copy Markdown
Member

Fixes the lints from the the latest Rustc version.

@jedel1043
jedel1043 requested a review from a team as a code owner August 26, 2026 15:28
@github-actions github-actions Bot added Waiting On Review Waiting on reviews from the maintainers C-Dependencies Pull requests that update a dependency file C-Tests Issues and PRs related to the tests. C-VM Issues and PRs related to the Boa Virtual Machine. C-Runtime Issues and PRs related to Boa's runtime features labels Aug 27, 2026
@github-actions

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,073 51,083 +10
Ignored 1,482 1,482 0
Failed 570 560 -10
Panics 0 0 0
Conformance 96.14% 96.16% +0.02%
Fixed tests (10):
test/built-ins/TypedArray/prototype/set/array-arg-src-tonumber-value-conversions.js (previously Failed)
test/built-ins/TypedArray/prototype/set/typedarray-arg-set-values-diff-buffer-other-type-conversions.js (previously Failed)
test/built-ins/TypedArray/prototype/fill/fill-values-conversion-operations.js (previously Failed)
test/built-ins/TypedArray/prototype/map/return-new-typedarray-conversion-operation.js (previously Failed)
test/built-ins/Math/f16round/value-conversion.js (previously Failed)
test/built-ins/DataView/prototype/setFloat16/set-values-return-undefined.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/object-arg/conversion-operation.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/conversion-operation.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/conversion-operation.js (previously Failed)
test/staging/sm/Math/f16round.js (previously Failed)

Tested main commit: 93a9e31a83bbaa15bbd8b687e61639ffc53bbef1
Tested PR commit: 82ac33fd1c4d7226b9d3933cd42a6b0316aef849
Compare commits: 93a9e31...82ac33f

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.79%. Comparing base (6ddc2b4) to head (82ac33f).
⚠️ Report is 1019 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/module/loader/mod.rs 0.00% 3 Missing ⚠️
core/runtime/src/fetch/fetchers.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5489       +/-   ##
===========================================
+ Coverage   47.24%   62.79%   +15.55%     
===========================================
  Files         476      530       +54     
  Lines       46892    59109    +12217     
===========================================
+ Hits        22154    37118    +14964     
+ Misses      24738    21991     -2747     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasonwilliams
jasonwilliams added this pull request to the merge queue Aug 27, 2026
Merged via the queue into boa-dev:main with commit 14846ea Aug 27, 2026
22 checks passed
@github-actions github-actions Bot removed the Waiting On Review Waiting on reviews from the maintainers label Aug 27, 2026
@jedel1043
jedel1043 deleted the rustc-1.98.0 branch August 27, 2026 13:51
jedel1043 added a commit to jedel1043/boa that referenced this pull request Aug 27, 2026
jedel1043 added a commit to jedel1043/boa that referenced this pull request Aug 27, 2026
…a-dev#5492)

Stacked on boa-dev#5489.

Makes it harder to have double borrows if the borrows are immediately
dropped.

Bug found by @Yanhaoxi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Dependencies Pull requests that update a dependency file C-Runtime Issues and PRs related to Boa's runtime features C-Tests Issues and PRs related to the tests. C-VM Issues and PRs related to the Boa Virtual Machine.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants