Skip to content

Use downcast on Date intrinsic to ensure borrows are not extended - #5492

Merged
jedel1043 merged 1 commit into
boa-dev:mainfrom
jedel1043:date-shorter-borrows
Aug 27, 2026
Merged

Use downcast on Date intrinsic to ensure borrows are not extended#5492
jedel1043 merged 1 commit into
boa-dev:mainfrom
jedel1043:date-shorter-borrows

Conversation

@jedel1043

@jedel1043 jedel1043 commented Aug 27, 2026

Copy link
Copy Markdown
Member

Stacked on #5489.

Makes it harder to have double borrows if the borrows are immediately dropped.

Bug found by @Yanhaoxi

@jedel1043
jedel1043 requested a review from a team as a code owner August 27, 2026 05:47
@github-actions github-actions Bot added C-Dependencies Pull requests that update a dependency file C-Builtins PRs and Issues related to builtins/intrinsics Waiting On Review Waiting on reviews from the maintainers labels Aug 27, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone Aug 27, 2026
@jedel1043
jedel1043 force-pushed the date-shorter-borrows branch 2 times, most recently from 0c5c410 to 3311dd3 Compare August 27, 2026 05:50
@github-actions github-actions Bot added C-Tests Issues and PRs related to the tests. C-VM Issues and PRs related to the Boa Virtual Machine. C-Runtime Issues and PRs related to Boa's runtime features labels Aug 27, 2026
@jedel1043
jedel1043 marked this pull request as draft August 27, 2026 05:51
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,083 51,083 0
Ignored 1,482 1,482 0
Failed 560 560 0
Panics 0 0 0
Conformance 96.16% 96.16% 0.00%

Tested main commit: 14846ead8fff8312fefa50deb6a64ede8584d7f3
Tested PR commit: ca7c8fb7e52c66fa4318f661c151c87d41d12044
Compare commits: 14846ea...ca7c8fb

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.79%. Comparing base (6ddc2b4) to head (ca7c8fb).
⚠️ Report is 1020 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5492       +/-   ##
===========================================
+ Coverage   47.24%   62.79%   +15.54%     
===========================================
  Files         476      530       +54     
  Lines       46892    59064    +12172     
===========================================
+ Hits        22154    37089    +14935     
+ Misses      24738    21975     -2763     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043
jedel1043 force-pushed the date-shorter-borrows branch from 3311dd3 to 6fed5ea Compare August 27, 2026 14:55
@jedel1043
jedel1043 marked this pull request as ready for review August 27, 2026 14:55
@jedel1043
jedel1043 force-pushed the date-shorter-borrows branch from 6fed5ea to e518e65 Compare August 27, 2026 14:56
@jedel1043
jedel1043 force-pushed the date-shorter-borrows branch from e518e65 to ca7c8fb Compare August 27, 2026 14:57
@jedel1043
jedel1043 added this pull request to the merge queue Aug 27, 2026
Merged via the queue into boa-dev:main with commit 60d4388 Aug 27, 2026
22 checks passed
@jedel1043
jedel1043 deleted the date-shorter-borrows branch August 27, 2026 17:49
@github-actions github-actions Bot removed the Waiting On Review Waiting on reviews from the maintainers label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Dependencies Pull requests that update a dependency file C-Runtime Issues and PRs related to Boa's runtime features C-Tests Issues and PRs related to the tests. C-VM Issues and PRs related to the Boa Virtual Machine.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants