Add interactive check to ready event handler - #1672
Merged
Merged
Conversation
If HTMX is imported in a module the readyState is "interactive" so the extension processing happens too late. This would fix it.
alexpetros
force-pushed
the
dsyer-interactive-pr
branch
from
August 4, 2023 23:07
08fe90b to
2244a36
Compare
Contributor
|
awesome, thank you @alexpetros and @dsyer! |
Contributor
|
Does this make #1485 obsolete? |
Collaborator
Author
|
I believe so, yes |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If HTMX is imported in a module the readyState is "interactive" so the extension processing happens too late. This would fix it.
Rebased version of: #1659