Move load tests to the bottom of the core file - #1677
Merged
Conversation
This "resolves" a timing bug that was ocurring in the CI, where these tests would run before htmx was loaded (only in the GitHub actions servers). Not proud of this as a fix but I would like the CI to work again ASAP.
alexpetros
added
devops
Contributor
|
oof |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This "resolves" a timing bug that was occurring in the CI, where these tests would run before the htmx was ready (only in the GitHub actions servers). Not proud of this as a fix but I would like the CI to work again ASAP.
The bug is related to the change from these PRs:
I still think the behavior in these PRs is correct. As best I can tell from MDN Documentation, the
loadingstate happens before all the deferred scripts are loaded butDOMContentLoadedfires after deferred scripts are loaded, even though the MDN page says "[loading] state indicates that the DOMContentLoaded event is about to fire". Which is what we want—we want it to be ready when the scripts are loaded, but we don't care if all the images are loaded.What needs to probably happen in the future is that we hold the tests until the ready event has fired.