Skip to content

fix: chart legend shows series names when not hovering #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andeplane merged 2 commits into from
Aug 15, 2026
Merged

fix: chart legend shows series names when not hovering #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ddd3b6
fix: chart legend shows series names when not hovering
andeplane Aug 15, 2026
54cde07
style: cap the always-visible legend footprint
andeplane Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/components/Figure.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ export const FigureGraph = ({
"#722ed1",
],
legendFormatter: function (data) {
if (data.x == null) {
return "";
}
// Without a hovered point (data.x == null) still list the series
// names and colors — an empty legend box reads as a bug.
const hovering = data.x != null;
let html = '<div class="dygraph-custom-legend">';
data.series.forEach(function (series) {
if (!series.isVisible) return;
Expand All @@ -161,7 +161,11 @@ export const FigureGraph = ({
'<span class="dygraph-legend-dot" style="color: ' +
color +
';">● </span>';
html += series.labelHTML + ": " + series.yHTML + "<br/>";
html += series.labelHTML;
if (hovering) {
html += ": " + series.yHTML;
}
html += "<br/>";
});
html += "</div>";
return html;
Expand Down
16 changes: 12 additions & 4 deletions src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,14 +425,22 @@ body,
color: #fff !important;
border: 1px solid #333 !important;
border-radius: 4px !important;
padding: 8px !important;
padding: 6px 8px !important;
/* The legend is always visible now: shrink to content (the library
default is a fixed 250px), cap its footprint on small charts, and
never intercept pointer events meant for the plot beneath it. */
width: auto !important;
max-width: 45% !important;
max-height: 45% !important;
overflow: hidden !important;
font-size: 11px !important;
line-height: 1.5 !important;
pointer-events: none !important;
}

.dygraph-custom-legend {
background: rgba(0, 0, 0, 0.8);
padding: 8px;
border-radius: 4px;
color: #fff;
white-space: nowrap;
}

.dygraph-legend-dot {
Expand Down
Loading