fix: chart legend shows series names when not hovering - #412
Merged
Conversation
The dygraphs legendFormatter returned an empty string whenever no point was hovered, so the always-on legend rendered as an empty box. Series names and color dots now stay visible; hover adds the values. Fixes #407 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review fix: the library default is a fixed 250px-wide legend with no height cap, which an always-on legend would let cover small charts (RunAnalysis figures go down to 320px). Shrink to content, cap at 45% of the chart, drop the double padding/background, and pass pointer events through to the plot. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dygraphs
legendFormatterreturned an empty string wheneverdata.x == null(no hovered point), so thelegend: "always"box rendered as an empty rectangle. The legend now always lists the series names with their color dots; hovering additionally shows the values, exactly as before.Fixes #407
🤖 Generated with Claude Code