Skip to content

Reduce unused code #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SimonDold wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Reduce unused code #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a2ed56
reduce unused code.
SimonDold Aug 12, 2026
02d00e0
style.
SimonDold Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/search/landmarks/landmark_factory_reasonable_orders_hps.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ void LandmarkFactoryReasonableOrdersHPS::insert_reasonable_orderings(
*/
void LandmarkFactoryReasonableOrdersHPS::approximate_reasonable_orderings(
const TaskProxy &task_proxy) {
State initial_state = task_proxy.get_initial_state();
for (const auto &node : *landmark_graph) {
const Landmark &landmark = node->get_landmark();
if (landmark.type == DISJUNCTIVE) {
Expand Down
17 changes: 2 additions & 15 deletions src/search/task_proxy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,9 @@
#include <string>
#include <vector>

class AxiomsProxy;
class ConditionsProxy;
class EffectProxy;
class EffectConditionsProxy;
class EffectsProxy;
class FactProxy;
class FactsProxy;
class GoalsProxy;
class OperatorProxy;
class OperatorsProxy;
class PreconditionsProxy;
class State;
class StateRegistry;
class TaskProxy;
class VariableProxy;
class VariablesProxy;

namespace causal_graph {
class CausalGraph;
Expand Down Expand Up @@ -556,8 +543,6 @@ class GoalsProxy : public ConditionsProxy {
}
};

bool does_fire(const EffectProxy &effect, const State &state);

class State {
/*
TODO: We want to try out two things:
Expand Down Expand Up @@ -640,6 +625,8 @@ class State {
State get_unregistered_successor(const OperatorProxy &op) const;
};

bool does_fire(const EffectProxy &effect, const State &state);

namespace utils {
inline void feed(HashState &hash_state, const State &state) {
/*
Expand Down
Loading