Reduce unused code - #310
Draft
SimonDold wants to merge 2 commits into
Draft
Conversation
SimonDold
marked this pull request as draft
August 12, 2026 21:20
Contributor
|
Was this created by accident? You did not replace the placeholder with the required content. Regarding the pull request, the forward declarations are not "unused code" but there intentionally. We thought it was clearer to forward-declare everything but think about what does or doesn't need forward declarations here. It also serves as an overview of the large collection of classes that work in a coordinated way. So this part is not something we should merge. The "get_initial_state" looks like it should go (but I didn't check context thoroughly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the pull request title, summarize the changes in imperative mood and prepend "[issueX]" where X is the issue number in our issue tracker (issues.fast-downward.org). The title will be suggested as the commit subject.
The commit message (i.e., this field) should highlight how the changes affect planner behavior:
Find our guidelines for commit messages in the Fast Downward Wiki (https://www.fast-downward.org/latest/for-developers/git/#git_conventions).