Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Hemera/Screen/ScreenManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,18 @@ final class ScreenManager {
if stayAwake && !isDimmed {
resetInactivityTimer()
}
case .background, .inactive:
case .background:
cancelInactivityTimer()
if isDimmed {
isDimmed = false
}
case .inactive:
/**
Transient interruptions (Control Center, Notification Center,
incoming calls) yield `.inactive` without backgrounding the app.
Keep the current dim state so it survives them.
*/
break
@unknown default:
break
}
Expand Down
23 changes: 23 additions & 0 deletions HemeraTests/Screen/ScreenManagerTests.swift
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import SwiftUI
import Testing
@testable import Hemera

Expand Down Expand Up @@ -61,4 +62,26 @@ struct ScreenManagerTests {
#expect(screenManager.isDimmed == true)
}

// MARK: - Scene Phase

@Test func handleScenePhase_inactive_whileDimmed_keepsDim() {
screenManager.stayAwake = true
screenManager.executePreviewDim()
#expect(screenManager.isDimmed == true)

screenManager.handleScenePhase(.inactive)

#expect(screenManager.isDimmed == true)
}

@Test func handleScenePhase_background_whileDimmed_clearsDim() {
screenManager.stayAwake = true
screenManager.executePreviewDim()
#expect(screenManager.isDimmed == true)

screenManager.handleScenePhase(.background)

#expect(screenManager.isDimmed == false)
}

}
Loading