Keep stay-awake dim on transient .inactive scene phase - #27
Merged
Conversation
ScreenManager.handleScenePhase lumped .inactive with .background and cleared isDimmed for both, so pulling down Control/Notification Center (which yields .inactive without backgrounding) defeated the stay-awake dim while the app was still foreground. Only clear the dim on a true .background trip; .inactive now does nothing, mirroring SessionManager.handleScenePhase's treatment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Split the combined
.background, .inactivecase inScreenManager.handleScenePhase(_:). A true.backgroundtrip still cancels the inactivity timer and clearsisDimmed;.inactivenow does nothing.Why
.inactiveis emitted for transient interruptions that don't background the app — pulling down Control Center or Notification Center, incoming-call banners, the app-switcher preview. Lumping it with.backgroundcleared the stay-awake dim overlay while the app was still foreground, defeating kiosk/stay-awake mode. This mirrors the siblingSessionManager.handleScenePhase, which already distinguishes the two (case .inactive: break).Notes
ScreenManagerTestscases:.inactivewhile dimmed keeps the dim;.backgroundwhile dimmed clears it.HemeraTestssuite green (369 tests)..inactiveis intentional — a dim firing behind Control Center is harmless (and arguably desired in kiosk mode); on return,.activere-arms only when not already dimmed.