Maven repositories + improved SKILL.md - #121
Open
matejcerny wants to merge 1 commit into
Open
Conversation
matejcerny
force-pushed
the
maven-config
branch
from
August 9, 2026 19:38
5ea7908 to
b0086dd
Compare
Contributor
|
LGTM but before I merge I want to run skill creator skill to double check those changes |
Contributor
|
Skill creator suggested leaving example block because it tell agent how it can grep it further etc. |
rochala
reviewed
Aug 17, 2026
|
|
||
| Run `cellar --version` to verify cellar is on PATH. If not found, the user | ||
| needs to install it: https://github.com/VirtusLab/cellar#installation | ||
| Look up JVM dependency APIs from the terminal. NEVER download or unpack JARs manually. |
Contributor
There was a problem hiding this comment.
Skill-creator suggested that leaving a reason will hold better and have better results
rochala
reviewed
Aug 17, 2026
| Prefer cellar **only** for external dependency API lookups (`cellar get-external` vs Metals `inspect`/`get-docs`): cellar requires no project import and works with any published Maven coordinate. For all other tasks — goto definition, find references, rename, diagnostics, compilation — use Metals. | ||
| cellar reads APIs, nothing else. | ||
| External coordinate → cellar. | ||
| Project classpath → Metals `inspect`/`get-docs`/`glob-search`, or cellar's project-aware commands when Metals is unavailable. |
Contributor
There was a problem hiding this comment.
We have to be extra careful with metals.
I got some comments / feedback that when they used it with IJ, it tried to install metals or something because of our skill. I'd be very explicit here so something more like:
Project classpath:
Metals MCP server if available > cellar project-aware commands
Compile, references, tests, formatting are not supported by cellar
rochala
added a commit
that referenced
this pull request
Aug 23, 2026
`MavenRepository.of` accepts any string verbatim, so a typo like a missing scheme survived until resolution failed — and it then failed as `CoordinateNotFound`, pointing at the coordinate with coordinate suggestions rather than at the repository that was actually wrong. Reject the URL at parse time instead: empty strings, unparseable URIs, a missing scheme, schemes other than http/https/file, and http(s) URLs with no host. The rejection reason carries no source prefix of its own, so the caller names where the URL came from; that keeps the config-file source #121 adds able to reuse the same check. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I've been using this updated skill for more than a week, so I can confirm it works correctly)