Conversation
`MavenRepository.of` accepts any string verbatim, so a typo like a missing scheme survived until resolution failed — and it then failed as `CoordinateNotFound`, pointing at the coordinate with coordinate suggestions rather than at the repository that was actually wrong. Reject the URL at parse time instead: empty strings, unparseable URIs, a missing scheme, schemes other than http/https/file, and http(s) URLs with no host. The rejection reason carries no source prefix of its own, so the caller names where the URL came from; that keeps the config-file source #121 adds able to reuse the same check. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123.
Scope
The issue names two repository sources: the
-r/--repositoryflag andmaven.repositoriesincellar.conf. The config source comes from #121, which is still open — there is no config-file repository path onmainyet. This PR fixes the pre-existing gap the issue calls out:-rwas never validated.RepositoryUrl.parsereturns the rejection reason without naming a source, so the caller supplies it. When #121 lands, its config path can reuse the same check and prefix reasons with the config file instead of the flag.What changed
cli/src/cellar/cli/RepositoryUrl.scala(new) —parse(raw): Either[String, MavenRepository]. Trims, then rejects empty strings, unparseable URIs, a missing scheme, schemes other thanhttp/https/file, andhttp(s)URLs with no host.cli/src/cellar/cli/CellarApp.scala—extraReposOptusesmapValidated, prefixing each reason withInvalid --repository:. Dropped the now-unusedMavenRepositoryimport.cli/test/src/cellar/cli/RepositoryUrlTest.scala(new) — 7 tests over accepted and rejected forms.README.md— the-rflag row states the accepted schemes.Verification
Rejected before, the bad URL and the flag both named:
Exits non-zero instead of surfacing later as
CoordinateNotFoundwith coordinate suggestions. A valid-r https://repo1.maven.org/maven2still renderscats.Monadcorrectly end-to-end../mill __.test(623 tasks) and./mill _.fix --checkboth pass.🤖 Generated with Claude Code