Skip to content

Wait for OAuth connect actionability instead of reading the first paint #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RhysSullivan merged 1 commit into from
Sep 1, 2026
Merged

Wait for OAuth connect actionability instead of reading the first paint #1828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion e2e/cloud/connection-modal-oauth-abandon.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,12 @@ scenario(
await visit(page, `/integrations/${integration}`);
await addConnection.click();
// The registered app is auto-selected, so the OAuth connect button is
// present and enabled.
// present and enabled. Auto-selection resolves asynchronously after
// the modal opens, so the button legitimately renders disabled for a
// beat first — wait for actionability (trial click waits for
// enabled + stable) rather than reading that transient first paint.
await connectWithOAuth.waitFor({ state: "visible", timeout: 15_000 });
await connectWithOAuth.click({ trial: true, timeout: 15_000 });
expect(
await connectWithOAuth.isDisabled(),
"the auto-selected app makes Connect with OAuth actionable",
Expand Down
Loading