Skip to content

Wait for OAuth connect actionability instead of reading the first paint - #1828

Merged
RhysSullivan merged 1 commit into
mainfrom
fix/oauth-abandon-actionability-race
Sep 1, 2026
Merged

Wait for OAuth connect actionability instead of reading the first paint#1828
RhysSullivan merged 1 commit into
mainfrom
fix/oauth-abandon-actionability-race

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

Fixes a new e2e flake: connection-modal-oauth-abandon failed twice within an hour on unrelated bases (runs 33153832122 on changeset-release, 33156980537) with the same assertion — "the auto-selected app makes Connect with OAuth actionable: expected true to be false".

The test waited for the button to be visible, then read isDisabled() once. The app picker's auto-selection resolves asynchronously after the modal opens, so the button legitimately renders disabled for a beat before enabling; the one-shot read raced that. It now waits for actionability (a trial click waits for enabled + stable) before the assertion. A genuine regression where the button never enables still fails, via the trial-click timeout.

Checks: lint, typecheck, focused cloud/connection-modal-oauth-abandon.test.ts run.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 28, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 98e2734 Aug 28 2026, 01:20 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 28, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 98e2734 Commit Preview URL

Branch Preview URL
Aug 28 2026, 01:20 PM

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@pkg-pr-new

pkg-pr-new Bot commented Aug 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1828

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1828

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1828

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1828

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1828

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1828

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1828

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1828

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1828

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1828

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1828

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1828

executor

npm i https://pkg.pr.new/executor@1828

commit: 98e2734

@RhysSullivan
RhysSullivan marked this pull request as ready for review September 1, 2026 05:02
@RhysSullivan
RhysSullivan merged commit 9c67fd5 into main Sep 1, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant