fix(analytics): report the shared contract revision in health - #40
Merged
Conversation
Deploying scientfactory-website with
|
| Latest commit: |
5897222
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98f0d4ea.scientfactory-website.pages.dev |
| Branch Preview URL: | https://fix-health-contract-revision.scientfactory-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analytics health endpoint reported revision 3 while its validator supported revision 4. It now reads ANALYTICS_CONTRACT_REVISION from the generated shared contract, so the health response follows the desktop producer version.
Validation: 32 gateway/contract tests passed, including the health response assertion; Worker TypeScript check and generated-source parity passed. No analytics permissions, activation flags, or notification behavior changes.
Documentation impact: None — corrects technical status metadata without changing collection or user workflows.
Companion desktop PR: ScientFactory/scient-desktop#271 moves the existing constant into the source of the generated contract. Either merge order is compatible.
Reviewed by GPT-6 in Codex desktop. CI provides full repository qualification.