Skip to content

fix(runtime): drop c_int imports left behind by the longjmp removal #9351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
Sep 1, 2026
Merged

fix(runtime): drop c_int imports left behind by the longjmp removal #9351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/9351-unused-c-int.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The `warnings` gate is green again. Five test modules in `perry-runtime` still
imported `std::os::raw::c_int` after the code that used it was removed, which
fails a `-D warnings` build.
1 change: 0 additions & 1 deletion crates/perry-runtime/src/native_abi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,6 @@ pub extern "C" fn js_native_abi_check_pod_object(value: f64) -> i64 {
#[cfg(test)]
mod tests {
use super::*;
use std::os::raw::c_int;

fn catch_runtime_throw(f: impl FnOnce()) -> bool {
crate::exception::catch_js_throw(f).is_err()
Expand Down
1 change: 0 additions & 1 deletion crates/perry-runtime/src/native_arena.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,6 @@ pub(crate) unsafe fn finalize_native_pod_view_for_gc(view: *mut NativePodViewHea
#[cfg(test)]
mod tests {
use super::*;
use std::os::raw::c_int;

fn boxed_ptr(ptr: *const u8) -> f64 {
f64::from_bits(crate::value::JSValue::pointer(ptr).bits())
Expand Down
1 change: 0 additions & 1 deletion crates/perry-runtime/src/native_handle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,6 @@ pub(crate) unsafe fn finalize_native_handle_for_gc(handle: *mut NativeHandleHead
#[cfg(test)]
mod tests {
use super::*;
use std::os::raw::c_int;

/// The teardown-diagnostics gate must block every thread except the
/// recorded owner — the unrecorded arm waving workers through is exactly
Expand Down
1 change: 0 additions & 1 deletion crates/perry-runtime/src/node_stream_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

use super::*;
use std::cell::RefCell;
use std::os::raw::c_int;

thread_local! {
pub(super) static WRITE_CAPTURED: RefCell<Vec<Vec<u8>>> = const { RefCell::new(Vec::new()) };
Expand Down
1 change: 0 additions & 1 deletion crates/perry-runtime/src/object/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#![cfg(test)]

use super::*;
use std::os::raw::c_int;

#[test]
fn call_method_depth_drop_is_idempotent_after_exception_restore() {
Expand Down
Loading