fix(runtime): drop c_int imports left behind by the longjmp removal - #9351
Conversation
The warnings gate fails on the release candidate with five instances of error: unused import: `std::os::raw::c_int` = note: `-D unused-imports` implied by `-D warnings` in native_abi.rs, native_arena.rs, native_handle.rs, node_stream_tests.rs and object/tests.rs. Each file contains exactly one occurrence of c_int -- the import itself -- so nothing references them. They are residue from #9305/#9323 ('no Rust frame is ever a longjmp target'), which removed the setjmp/longjmp call sites that took c_int arguments but left the imports behind. ffi/setjmp.rs keeps its import: it still uses c_int 16 times for the real extern signature.
78a166d to
1fa45a7
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (5)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughFour unused ChangesWarnings cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR removes unused imports without changing runtime behavior, so no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description gives a detailed problem statement and explains the affected files, cause, retained import, and release impact. It does not follow the repository template and omits the required Summary, Changes, Related issue, Test plan, and Checklist sections. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The
warningsgate fails on the release candidate (e539a6359e, run 33457888163) with five instances of the same error:Also
native_arena.rs:475,native_handle.rs:411,node_stream_tests.rs:6,object/tests.rs:5.Each of those files contains exactly one occurrence of
c_int— the import itself — so nothing references them. They are residue from #9305/#9323 ("no Rust frame is ever a longjmp target"), which removed thesetjmp/longjmpcall sites that tookc_intarguments but left the imports.ffi/setjmp.rskeeps its import: it still usesc_int16 times for the real extern signature (unsafe extern "C" fn(*mut c_int) -> c_int). I checked that one specifically rather than removing every match.warningsis infull-suite-gate'sneeds, so this blocks the v0.5.1519 release.Why the PR tier missed it
Worth a look from someone who knows the tier layout better than I do: these are all
#[cfg(test)]modules, so they only surface in a build that includes test targets. If the PR tier'swarningsstep doesn't cover--all-targetsfor the affected crate, or scopes to the diff, an unused import inside a test module can land without ever being compiled. That would make this class recur.Summary by CodeRabbit
Chores
Documentation