feat(theme): readable theme colors via useColors() + inline style - #7
Merged
Conversation
…liance on Tailwind color utilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes low-contrast, theme-ignoring colors across the app. Brass accent colors were used as
text/fills at 2.6–2.9:1 on light surfaces, CTA button labels were near-black on mid-brown
(muddy), the enabled toggle barely read against light cards, and several screens (onboarding
PIN, lock) were hardcoded to a single palette. Additionally, Tailwind color classes don't
follow the runtime dark/light theme in this project, so all colors now come from
useColors()+ inlinestyle.What changed
New theme tokens (
src/types/theme.ts,src/theme/,src/global.css)brassText#8F5636(5.2:1)#C87B54brassButton#A3542E#C87B54buttonLabel#F3EEE1cream (4.7:1)#1B1F1AinkUI updates
cream labels (button also stands out 4.8:1 vs the page). Dark mode unchanged (ink on brass,
5.1:1).
brassText; thumb is parchment — reads clearly on light cards./lockand the onboarding PIN setup now follow the theme (previouslyhardcoded light); onboarding stack background too.
Convention change (AGENTS.md)
against the
:rootlight values;Appearance.setColorScheme()doesn't flip the evaluatedmedia query).
useColors()+ inlinestyle;classNameonly for non-colorlayout. Hard Rule #15 updated; §8.1–8.6 and §8.10 rewritten.
Full sweep (~80 sites, 25 files)
bg-surface-bg,text-text-primary,text-brass*,border-hairline,text-rust, …) to inline styles.edit-account,settingsSectionLabel,ReceiptScanResult,receipt-scan) — labels rendered darkvalues in light mode.
CategoryRingCardpercent text was ink-on-dark in dark mode →textPrimary.Verification
tsc --noEmit✅eslint src✅ (prettier clean)bun test: 70 pass / 14 fail — identical tomainbaseline (pre-existing environmentissue: react-native flow types under Bun; no regressions)
Notes
SlothAppIconbrand SVG untouched (static artwork, not a theme color).