Advertise the REST endpoint during Consul registration - #2170
Merged
Conversation
Add the running REST endpoint to Consul metadata and replace wildcard bind addresses with the server IP. NO-ISSUE
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use the local interface selected for the configured Consul host when the REST API binds to wildcard addresses. NO-ISSUE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0.0.0.0,::, and wildcard-only address lists with the local interface selected by the OS route to ConsulWhy
Consul must advertise and health-check a reachable MapsMessaging address. A wildcard bind address is valid for listening but cannot be used by Consul clients.
For example, when Consul is at
10.140.62.193:8500, route-based selection advertises the Ethernet address10.140.62.146, rather than an APIPA or Hyper-V adapter address.Companion change
Configuration library PR: Maps-Messaging/configuration_library#47
Validation
Added focused tests for configured addresses, IPv4 wildcard replacement, wildcard lists, IPv6 formatting, and invalid ports. The companion library tests cover route selection and invalid Consul URLs.
git diff --checkpasses.The Maven test could not run in the available environment because the MapsMessaging and Maven repositories are not reachable and no dependency cache is available.