Register the MapsMessaging REST endpoint with Consul - #47
Merged
Conversation
Use the advertised REST endpoint for the Consul service address, port, metadata, and TCP health check. NO-ISSUE
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolve the local interface address chosen to reach the configured Consul host. NO-ISSUE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
restendpoint from service metadataWhy
The existing registration advertises a hard-coded port and asks the Consul agent to check
localhost. That checks the Consul agent's host rather than the MapsMessaging server when Consul is remote.Route-based address selection also avoids advertising an unrelated interface on multi-homed systems.
Companion change
MapsMessaging server PR: Maps-Messaging/mapsmessaging_server#2170
Validation
Added focused tests covering IPv4, IPv6, missing endpoints, malformed endpoints, wildcard addresses, route-based local-address selection, and invalid Consul URLs.
git diff --checkpasses.The Maven test could not run in the available environment because Maven Central is not reachable and no dependency cache is available.