Skip to content

Extend module type related limitation #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fantazio merged 3 commits into from
Aug 4, 2026
Merged

Extend module type related limitation #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6d0e06
[check] unveil a false positive
fantazio Aug 3, 2026
0bf7380
[examples][docs] move sigincl limitation
fantazio Aug 3, 2026
fbd4521
[examples][docs][limitations] move and generalize sigincl into modtype
fantazio Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions check/classic/classic.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,8 +660,6 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/exported_values/limitations/sigincl/sigincl_lib.ml:9: unit pattern x

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)

Expand Down
63 changes: 56 additions & 7 deletions check/classic/classic.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:25: id: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:40: new_method: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:41: public_method_label: Should not be detected
./examples/docs/exported_values/limitations/sigincl/sigincl_lib.mli:10: I.x: Should not be detected
./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj
Expand Down Expand Up @@ -171,6 +170,34 @@ Nothing else to report in this section

.> UNUSED METHODS:
=================
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Ftor_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Incl.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Incl_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: With.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Ftor_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Incl.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Incl_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: With.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: Subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: Subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: Incl_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: Incl_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: Ftor_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: Ftor_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Ftor_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Incl.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Incl_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: With.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Ftor_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Incl.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Incl_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: With.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: Subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: Subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: Incl_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: Incl_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: Ftor_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: Ftor_subst.o#m: Should not be detected
./examples/docs/methods/code_constructs/class/class_bin.ml:2: unused_class#unused_method
./examples/docs/methods/code_constructs/class/class_lib.mli:2: int_stack#reset

Expand Down Expand Up @@ -264,6 +291,14 @@ Nothing else to report in this section
./examples/docs/fields_and_constructors/code_constructs/polymorphic_type/polymorphic_type_lib.mli:2: either.Right
./examples/docs/fields_and_constructors/code_constructs/polymorphic_type/polymorphic_type_lib.mli:3: both.left

./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Ftor_with.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Incl.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Incl_with.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: With.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Ftor_with.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Incl.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Incl_with.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: With.field.field: Should not be detected
./examples/using_dune/preprocessed_lib/preprocessed.mli:14: constructors.Unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:19: constr_with_eq.Unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:23: record.unused
Expand Down Expand Up @@ -340,6 +375,14 @@ Nothing else to report in this section
=============================
./examples/docs/coding_style/opt/opt.ml:15: ?index

./examples/docs/limitations/modtype/modtype_with_intf.mli:9: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:9: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: ?always: Should not be detected
./examples/docs/optional_arguments/code_constructs/external_app/external_app_lib.mli:3: ?max

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: ?index
Expand Down Expand Up @@ -501,6 +544,14 @@ Nothing else to report in this section

.> OPTIONAL ARGUMENTS: NEVER:
============================
./examples/docs/limitations/modtype/modtype_with_intf.mli:9: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:9: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: ?never: Should not be detected
./examples/docs/optional_arguments/code_constructs/external_app/external_app_lib.mli:2: ?min

./examples/docs/optional_arguments/code_constructs/internal_app/internal_app_lib.ml:2: ?min
Expand Down Expand Up @@ -665,8 +716,6 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/exported_values/limitations/sigincl/sigincl_lib.ml:9: unit pattern x

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)

Expand Down Expand Up @@ -719,7 +768,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 593
Success: 586
Failed: 7
Ratio: 98.8195615514%
Total: 643
Success: 585
Failed: 58
Ratio: 90.9797822706%
2 changes: 0 additions & 2 deletions check/internal/internal.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,8 +612,6 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/exported_values/limitations/sigincl/sigincl_lib.ml:9: unit pattern x

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)

Expand Down
63 changes: 56 additions & 7 deletions check/internal/internal.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:25: id: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:40: new_method: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:41: public_method_label: Should not be detected
./examples/docs/exported_values/limitations/sigincl/sigincl_lib.mli:10: I.x: Should not be detected
./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj
Expand Down Expand Up @@ -123,6 +122,34 @@ Nothing else to report in this section

.> UNUSED METHODS:
=================
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Ftor_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Incl.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Incl_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: With.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Ftor_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Incl.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Incl_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: With.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: Subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: Subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: Incl_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: Incl_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: Ftor_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: Ftor_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Ftor_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Incl.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Incl_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: With.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Ftor_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Incl.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Incl_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: With.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: Subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: Subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: Incl_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: Incl_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: Ftor_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: Ftor_subst.o#m: Should not be detected
./examples/docs/methods/code_constructs/class/class_bin.ml:2: unused_class#unused_method
./examples/docs/methods/code_constructs/class/class_lib.mli:2: int_stack#reset

Expand Down Expand Up @@ -216,6 +243,14 @@ Nothing else to report in this section
./examples/docs/fields_and_constructors/code_constructs/polymorphic_type/polymorphic_type_lib.mli:2: either.Right
./examples/docs/fields_and_constructors/code_constructs/polymorphic_type/polymorphic_type_lib.mli:3: both.left

./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Ftor_with.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Incl.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Incl_with.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: With.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Ftor_with.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Incl.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Incl_with.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: With.field.field: Should not be detected
./examples/using_dune/preprocessed_lib/preprocessed.mli:14: constructors.Unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:19: constr_with_eq.Unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:23: record.unused
Expand Down Expand Up @@ -292,6 +327,14 @@ Nothing else to report in this section
=============================
./examples/docs/coding_style/opt/opt.ml:15: ?index

./examples/docs/limitations/modtype/modtype_with_intf.mli:9: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:9: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: ?always: Should not be detected
./examples/docs/optional_arguments/code_constructs/external_app/external_app_lib.mli:3: ?max

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: ?index
Expand Down Expand Up @@ -453,6 +496,14 @@ Nothing else to report in this section

.> OPTIONAL ARGUMENTS: NEVER:
============================
./examples/docs/limitations/modtype/modtype_with_intf.mli:9: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:9: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: ?never: Should not be detected
./examples/docs/optional_arguments/code_constructs/external_app/external_app_lib.mli:2: ?min

./examples/docs/optional_arguments/code_constructs/internal_app/internal_app_lib.ml:2: ?min
Expand Down Expand Up @@ -617,8 +668,6 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/exported_values/limitations/sigincl/sigincl_lib.ml:9: unit pattern x

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)

Expand Down Expand Up @@ -671,7 +720,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 549
Success: 542
Failed: 7
Ratio: 98.7249544627%
Total: 599
Success: 541
Failed: 58
Ratio: 90.3171953255%
3 changes: 0 additions & 3 deletions check/threshold-1/threshold-1.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,6 @@ Nothing else to report in this section
./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#used_fun
./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#used_int

./examples/using_make/advanced/func.mli:3: M.c#f
./examples/using_make/advanced/mod.mli:4: p#f

./examples/using_make/obj/class.mli:1: c#f
Expand Down Expand Up @@ -1069,8 +1068,6 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/exported_values/limitations/sigincl/sigincl_lib.ml:9: unit pattern x

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)

Expand Down
Loading
Loading