Extend module type related limitation - #91
Merged
Conversation
Content of module types should not be tracked according to the analyzer's semantics. An old example's expected results were not updated when the semantics were decided, hiding a false positive as a true positive.
The limitation was in the exported values. It is now a general limitation. A new `examples/docs/limitations` was created to expose general limitations. The documentation, expected, and ref results have been updated accordingly. The module type limitation is now documented as a general limitations as well.
fantazio
force-pushed
the
tests
branch
2 times, most recently
from
August 3, 2026 14:53
a1b99f9 to
7f1eb24
Compare
Extend the test to all supported constructs. It now shows the limitation on constructors, fields, methods, and optional values. The documentation, expected, and ref results have been updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "sigincl" limitation was only documented for exported values (related issue #64).
However, the analyzer semantics on module types are for all code elements. Hence, the limitation was extended to "modtype" and is now documented as a general limitation and the corresponding test manipulates all reportable element kinds.
In addition, a related false positive was unveiled in
examples/using_make. The corresponding test's expected results were not updated to reflect the restriction on module types.