Skip to content

update DCClsComboEngine.java to set limit for cluster combos in case of memory explosion #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tongtongcao wants to merge 1 commit into
base: development
Choose a base branch
from
Open

update DCClsComboEngine.java to set limit for cluster combos in case of memory explosion #1352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions reconstruction/ai/src/main/java/org/jlab/service/ai/DCClsComboEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ public class DCClsComboEngine extends ReconstructionEngine {

final static String CONF_THREADS = "threads";

final static String LIMIT_CLSCOMBOS_PERSECTOR = "limitClsCombosPerSector";
int limitClsCombosPerSector = (int)1e6;

final static String CONF_MODEL_FILE_6CLS = "modelFile6Cls";
final static String CONF_THRESHOLD_6CLS = "threshold6Cls";
String modelFile6Cls = "mlp_64h_4l_6cls.pt";
Expand All @@ -51,7 +54,7 @@ public class DCClsComboEngine extends ReconstructionEngine {
Criteria<float[][], float[]> criteria5Cls;
ZooModel<float[][], float[]> model5Cls;
PredictorPool predictors5Cls;

final static int SUPERLAYERS = 6;

public DCClsComboEngine() {
Expand All @@ -69,6 +72,9 @@ public boolean init() {

int threads = Integer.parseInt(getEngineConfigString(CONF_THREADS,"64"));

if (getEngineConfigString(LIMIT_CLSCOMBOS_PERSECTOR) != null)
limitClsCombosPerSector = Integer.parseInt(getEngineConfigString(LIMIT_CLSCOMBOS_PERSECTOR));

if (getEngineConfigString(CONF_THRESHOLD_6CLS) != null)
threshold6Cls = Float.parseFloat(getEngineConfigString(CONF_THRESHOLD_6CLS));
if (getEngineConfigString(CONF_MODEL_FILE_6CLS) != null)
Expand Down Expand Up @@ -340,6 +346,9 @@ public void writeBank(DataEvent event, List<DCClusterCombo> clsComboList){
*/
public void generate6ClsCombos(Map<Integer, List<DCCluster>> map, int sl, DCCluster[] current, List<DCClusterCombo> comboList) {

// Limit for combos
if (comboList.size() >= limitClsCombosPerSector) return;

// Base case: if all superlayers have been processed (sl > 6)
// then we have a complete 6-cluster combination
if (sl > SUPERLAYERS) {
Expand Down Expand Up @@ -368,7 +377,7 @@ public void generate6ClsCombos(Map<Integer, List<DCCluster>> map, int sl, DCClus
*/
public void generate5ClsCombos(Map<Integer, List<DCCluster>> mapSL,
List<DCClusterCombo> outputList) {

// Iterate over all possible missing superlayers (1 to 6)
for (int missingSL = 1; missingSL <= SUPERLAYERS; missingSL++) {

Expand Down Expand Up @@ -404,6 +413,9 @@ private void generate5ClsRecursive(Map<Integer, List<DCCluster>> mapSL,
DCCluster[] current,
int idx,
List<DCClusterCombo> outputList) {

// Limit for combos
if (outputList.size() >= limitClsCombosPerSector) return;

// Base case: all superlayers processed
if (sl > SUPERLAYERS) {
Expand Down
Loading