update DCClsComboEngine.java to set limit for cluster combos in case of memory explosion#1352
Open
tongtongcao wants to merge 1 commit into
Open
update DCClsComboEngine.java to set limit for cluster combos in case of memory explosion#1352tongtongcao wants to merge 1 commit into
tongtongcao wants to merge 1 commit into
Conversation
…of memory explosion
Collaborator
|
Isn't 1e6 very conservative? Your data stops at 8e4? |
Collaborator
|
And what's the max memory needed for 1e6? |
Collaborator
Author
|
The test is after denoising, and run 6666 is 50nA. Consider much higher luminosity for the future and potential reconstruction without denoising, I set much higher value for limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response to #1336, set limit for DC cluster combos.
By default, limit is 1M for each sector. If combos reach the limit for a sector, then the first 1M combos will be kept.
Totally, the memory usage is estimate to be ~1.8G at most, if all 6 sectors reach the default limit.
Limit of 1M is supposed to be large enough. The plot show distribution for # of combos of a sector using run 6666 for test.