chore(deps): update volta-cli/action action to v5 - #60
Closed
renovate[bot] wants to merge 5 commits into
Closed
Conversation
…ards Root-cause fixes found in pre-release review of v1.5.0: - PMT: explicit zero-rate branch ((pv+fv)/nper) instead of dividing by zero and returning NaN. Fixes mortgageCalculator (repayment), earlyMortgagePayoff, and the debt-repayment path at a 0% rate, which previously produced "£NaN" / a bogus "paid off in 1 month" result. - toDecimalRate: always divide by 100. Drops the ambiguous "rate >= 1 ? rate/100 : rate" heuristic that misread a genuine sub-1% rate (e.g. a 0.5% safe-withdrawal rate) as 50%. The three new calculators are now percentage-only (6 = 6%, 0.5 = 0.5%). - solveYearsToGoal: validate all inputs (incl. new startingBalance < 0 guard) before the "already met the target" early return. - solveYearsToGoal / yearsToFire: reject rates of -100% or lower that would NaN the Math.log solve. Tests expanded 45 -> 76 (97% stmts, 92% branch, 100% functions), covering the zero-rate, sub-1%, non-monthly-compounding, and guard branches. CHANGELOG updated with the percentage-only behaviour change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The release workflow runs `npm version <tag>` against main and commits the bump itself (as it did for v1.4.1 and earlier — the v1.4.1 tag's package.json still read 1.4.0). The branch had pre-bumped to 1.5.0, which would make that step fail with "Version not changed". Revert to 1.4.1 so `gh release create v1.5.0` triggers a clean bump-and-publish. CHANGELOG keeps the 1.5.0 entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Per-repo guidance for agents/contributors: setup, commands, layout, conventions (rates are percentages, calculators throw on bad input), and the automated release flow. CLAUDE.md points to AGENTS.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat: v1.5.0 — savings goal, early payoff, FIRE calculators
Contributor
Author
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v4→v5Release Notes
volta-cli/action (volta-cli/action)
v5.0.0Compare Source
💥 Breaking Change
Committers: 1
v5Compare Source
💥 Breaking Change
Committers: 1
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.