Skip to content

chore: eslint 10 + typescript-eslint 8 flat config, CI action bumps, hardened release - #61

Merged
JDIZM merged 3 commits into
mainfrom
chore/deps-and-ci
Jun 30, 2026
Merged

chore: eslint 10 + typescript-eslint 8 flat config, CI action bumps, hardened release#61
JDIZM merged 3 commits into
mainfrom
chore/deps-and-ci

Conversation

@JDIZM

@JDIZM JDIZM commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Consolidates the open dependency/CI update PRs.

ESLint flat-config migration (closes #24, #29)

  • eslint 8 → 10, @typescript-eslint/* 7 → typescript-eslint 8
  • .eslintrc.cjs → flat eslint.config.mjs
  • dropped eslint-plugin-import + eslint-import-resolver-alias (the @ → ./src alias was dead — no src/ — and TypeScript already validates imports)
  • .eslintignore folded into the config ignores; removed the deprecated --ext flag

CI (closes #49, #59, #60)

  • actions/checkout v5 → v7, volta-cli/action v4 → v5, actions/setup-node v5 → v6 (clears the deprecated-Node-20-actions warnings)
  • test matrices: node [20, 22, 24][22, 24]
  • release.yml hardened: npm version --allow-same-version + only commit when the version actually changed, so a pre-bumped branch can't break a release (the exact failure mode from the v1.5.0 release)

Verified locally: lint, format:check, tsc:check, test (76 passed, 97% coverage), build all green.

Closes #24, #29, #49, #59, #60.

JDIZM added 2 commits June 30, 2026 13:03
- eslint 8 -> 10, @typescript-eslint/* 7 -> typescript-eslint 8
- replace .eslintrc.cjs with a flat eslint.config.mjs
- drop eslint-plugin-import + eslint-import-resolver-alias: the @ -> ./src
  alias was dead (no src/ dir) and TypeScript already validates imports
- migrate .eslintignore into the config's ignores; drop the --ext flag

lint, format:check, tsc:check, test (76) and build all pass.
- actions/checkout v5 -> v7, volta-cli/action v4 -> v5, setup-node v5 -> v6
  (clears the deprecated-Node-20-actions warnings)
- test matrices: node [20, 22, 24] -> [22, 24]
- release.yml: npm version --allow-same-version + only commit when the
  version actually changed, so a pre-bumped branch can't break a release

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's ESLint configuration to the flat config format (eslint.config.mjs), upgrading ESLint to v10 and updating related dependencies. The review feedback correctly identifies that the Prettier configuration is not placed at the end of the configuration array, which contradicts the inline comment and may prevent it from overriding conflicting formatting rules in subsequent custom blocks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread eslint.config.mjs Outdated
Per PR review: prettier was placed before the custom rule blocks despite the
comment saying it must be last. Move it to the end so it reliably overrides
any conflicting formatting rules.
@JDIZM
JDIZM merged commit 5a39033 into main Jun 30, 2026
2 checks passed
@JDIZM
JDIZM deleted the chore/deps-and-ci branch June 30, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant