Fix some texture related YML issues - #7036
Open
louist103 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
oh no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these were just outdated and had bugs that were fixed in decomp. Found these when using torch to extract textures to RGBA32 using the TLUTs.
The skyboxes needed to use segment 1 for the main section and segment 128 for the palettes. They should both use segment 0 but I couldn't get the data extracted correctly using that, so I had to use 1 for the skybox and 128 for the palette. If there is a better way to make torch extract an external TLUT which shares an offset with something in the main object I'd like to do that.
I will need to do more testing to make sure nothing broke but I think its fine.
Build Artifacts