Dedup skyboxes and BG YMLs with symlinks - #7075
Open
louist103 wants to merge 16 commits into
Open
Conversation
Member
|
@Pepe20129 we should be able to use something like |
Member
louist103
added
do not merge
Contributor
Author
|
The filelists should all be good. I need to revert the changes from #7036 then it should be good. |
briaguya0
reviewed
Aug 23, 2026
Contributor
Author
|
Turns out Windows doesn't really support symlinks outside of developer mode. We will probably need to discuss this further. |
Contributor
Author
|
Symlinks have been removed. HarbourMasters/Torch#257 is open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other than the offsets the YMLs for skyboxes and BGs are the same across all versions. I decided to use symlinks to make torch think YMLs exist for every version when in reality they were all moved into a common directory.
I had to add a few things to Torch for this.
1.
common_pathnode in the rom config. This tells torch where to look for YMLs common to all versions.${VER} tag for paths. This tells torch to use thepathattribute in the version config file to find external files.2. tlut_symbol. This already existed in Torch but ship didn't use it. Its not required for this PR but I will need it for something else and it helped me make sure all the paths were setup correctly.
3. HarbourMasters/Torch#255 The PR making this possible and blocking merging this one.
The last thing that needs to be done on the Ship side is to finish creating the filelists for the debug roms.
Something I want to add later but is out of scope here is checking if the skybox files exist. Right now if they don't random garbage data is drawn instead of the skybox or a crash.
I plan on doing the rest of the assets but I think it should be done in groups instead of all at once.
I also need to figure out what to do with #7036 since it also touches the skyboxes. I think the best plan is to just revert the skybox stuff it touches and merge the rest.
Build Artifacts