Retain stacking contexts with spatial bounds - #809
Open
nicoburns wants to merge 3 commits into
Open
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1787777503-retained-stacking-bounds
branch
from
August 26, 2026 21:24
ac20165 to
0c75649
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1787777503-retained-stacking-bounds
branch
from
August 26, 2026 21:27
0c75649 to
3ddbc8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace out-of-flow paint-tree reparenting with retained, context-owned stacking lists built from structural paint order while preserving layout ancestry and containing-block geometry.
Resolve geometry separately, then compute each context's transformed retained-content bound for paint and hit-test pruning. Bounds are dirtied through stacking ownership when layout or
scrollable_overflowgeometry changes; fixed-position and independently scrolled entries conservatively disable pruning rather than risk stale culling.This supersedes #806 while deliberately omitting its later inline containing-block experiments.
WPT results
143 newly passing, 35 newly failing (net +108).
Full diff (178 changed tests)
Generated by the WPT workflow.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/b6714d5757fa4fa7b858caed09087cdb
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/b6714d5757fa4fa7b858caed09087cdb?variant=devin-insiders
Requested by: @nicoburns